* b2c2: flexcop: avoid unused function warnings + struct sd *sd = (struct sd *) gspca_dev struct sd *sd = (struct sd *) gspca_dev +++ -243,7 +243,9 static int sd_start(struct gspca_dev *gspca_dev)ĭiff -git a/drivers/media/usb/gspca/t613.c b/drivers/media/usb/gspca/t613.c Static void sd_stopN(struct gspca_dev *gspca_dev)ĭiff -git a/drivers/media/usb/gspca/konica.c b/drivers/media/usb/gspca/konica.c This encloses the declarations in #ifdef CONFIG_INPUT, just likeįixes: ee186fd96a5f (" gscpa_t613: Add support for the camera button")įixes: c2f644aeeba3 (" gspca_cpia1: Add support for button")įixes: b517af722860 ("V4L/DVB: gspca_konica: New gspca subdriver for konica chipset using cams")ģ files changed, 6 insertions(+), 1 deletion(-)ĭiff -git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c Media/usb/gspca/konica.c:246:13: error: unused variable 'sd' Media/usb/gspca/konica.c: In function 'sd_stopN': Media/usb/gspca/cpia1.c:1627:13: error: unused variable 'sd' Media/usb/gspca/cpia1.c: In function 'sd_stopN': Print compile-time warnings about unused variables: When CONFIG_INPUT is disabled, multiple gspca backend drivers Leandro Costantino, linux-media, linux-kernel ` (5 subsequent siblings) 7 siblings, 1 reply 18+ messages in threadĬc: linux-arm-kernel, Arnd Bergmann, Hans Verkuil, 14:09 ` b2c2: flexcop: avoid unused function warnings Arnd Bergmann 14:09 ` hdpvr: hide unused variable Arnd 14:09 ` Arnd Bergmann 14:09 pwc: hide unused label Arnd Bergmann Struct usb_endpoint_descriptor *endpoint +++ -273,7 +273,9 static int hdpvr_probe(struct usb_interface *interface, This uses the same #ifdef to hide the variable when the code usingĭrivers/media/usb/hdpvr/hdpvr-core.c | 2 ++ĭiff -git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c Otherwise produces a compile-time warning:ĭrivers/media/usb/hdpvr/hdpvr-core.c: In function 'hdpvr_probe':ĭrivers/media/usb/hdpvr/hdpvr-core.c:276:21: error: unused variable 'client' The i2c client pointer is only used when CONFIG_I2C is set, and ` (6 subsequent siblings) 7 siblings, 0 replies 18+ messages in thread 14:09 ` gspca: avoid unused variable warnings Arnd Bergmann 14:09 pwc: hide unused label Arnd 14:09 ` Arnd Bergmann +++ -1106,14 +1106,13 static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id So we can just move it inside of the existing #ifdef and remove theġ file changed, 2 insertions(+), 3 deletions(-)ĭiff -git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c Obviously, the cleanup of &pdev->vdev is not needed without the input device, The pwc driver causes a warning when CONFIG_USB_PWC_INPUT_EVDEV is unset:ĭrivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe':ĭrivers/media/usb/pwc/pwc-if.c:1115:1: warning: label 'err_video_unreg' defined but not used ` (7 more replies) 0 siblings, 8 replies 18+ messages in threadįrom: Arnd Bergmann 14:09 UTC ( / raw)Ĭc: linux-arm-kernel, Arnd Bergmann, Hans Verkuil, linux-media, linux-kernel 14:09 ` hdpvr: hide unused variable Arnd Bergmann Pwc: hide unused label LKML Archive on help / color / mirror / Atom feed * pwc: hide unused label 14:09 Arnd Bergmann
0 Comments
Leave a Reply. |
Details
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |